Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-console): Add URL deep-linking for UI panels #248

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(web-console): Add URL deep-linking for UI panels #248

wants to merge 8 commits into from

Conversation

insmac
Copy link
Contributor

@insmac insmac commented Dec 1, 2023 •
edited
Loading

Add URL deep-linking for the UI panels:

?topPanel=p1 (default: p1 - tables - this is future-proofing, as there will be more in near future)
?bottomPanel=p0|p1|p2 (default: p0)
?sidebar=p1|p2 (default: none)

Panel alignment screenshot:
web-console-panels

EDIT: Closes #245

@insmac insmac added the web-console Issues relevant to "web-console" package label Dec 1, 2023
@bluestreak01
Copy link
Member

We could assign panels and their states integer IDs, this way we can keep backward compatibility even if UI changes. Dependency on panel human readable names is not ideal.

bluestreak01
bluestreak01 requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@bluestreak01 bluestreak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have less that 3 tables to have zero-state panel visible, go to this URL: http://localhost:9999/?bottomPanel=result execute a query and observe query result not being displayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluestreak01 bluestreak01 bluestreak01 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
web-console Issues relevant to "web-console" package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route directly to CSV Import flow from URL
2 participants
@insmac @bluestreak01